Removing UnitConverters from v4 #2459
Merged
+186
−448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that entire converters file can be removed
Keeping it only for VectorField.eval()
Base automatically changed from
unitconversion_for_cgridvelocity
to
fieldset_from_nemo
January 12, 2026 13:17
Contributor
|
I think this makes sense. Also what you mentioned @erikvansebille about having velocity handle the unit conversion of velocities to be relative to the grid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #2455, when we realised that we don't actually rely on UnitConverters for the VectorField interpolation. That means that we don't need
UnitConvertersat all. And since they were a bit of a beast to work with, this PR removes them altogether 🥳The only downside, as far as I can see, is that sampling
fieldset.Uorfieldset.Vseparately (so not asfieldset.UV) leads to velocities that are not converted from m/s to degrees/s, so can't be used inside kernels (unless users do the conversion themselves)